Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive.combine: set allowSubstitutes = true #107204

Merged
merged 1 commit into from Dec 24, 2020
Merged

texlive.combine: set allowSubstitutes = true #107204

merged 1 commit into from Dec 24, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 19, 2020 •
edited

Motivation for this change

Another attempt to fix #88045

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Dec 20, 2020
@veprbl veprbl merged commit 96186b2 into NixOS:master Dec 24, 2020
@veprbl veprbl deleted the pr/texlive_substitute_from_hydra branch December 24, 2020 23:32
@xaverdh
Copy link
Contributor

xaverdh commented Dec 25, 2020

Glad if this fixes the issue. Not sure if I understand why this is needed though, shouldn't substitution be the default behavior anyway?

@veprbl
Copy link
Member Author

veprbl commented Dec 25, 2020

Turns out that buildEnv hardcodes it for false, which makes sense, but in our case we also do a postBuild that is somewhat heavy.

@xaverdh
Copy link
Contributor

xaverdh commented Dec 25, 2020

Turns out that buildEnv hardcodes it for false, which makes sense, but in our case we also do a postBuild that is somewhat heavy.

Ah I see!

@xworld21 xworld21 mentioned this pull request Jun 10, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Since installing texlive.combined.scheme-full, system updates cause recompilations
2 participants
@veprbl @xaverdh