Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stern: use stern/stern as upstream source #107202

Merged
merged 1 commit into from Dec 20, 2020
Merged

stern: use stern/stern as upstream source #107202

merged 1 commit into from Dec 20, 2020

Conversation

Preisschild
Copy link
Contributor

@Preisschild Preisschild commented Dec 19, 2020 •
edited

Motivation for this change

closes #107015

wrecker/stern hasn't received any commits since 2019.
The maintainer of stern doesn't work at wercker anymore, and it seems noone else there is maintaining it (https://github.com/wercker/stern/issues/140).

The community has since moved to stern/stern with improvements to the original source.

Things done

Since the stern/stern repo has moved to Gomod, I had to refactor this package a bit.
I also added myself as a maintainer, so i can help keeping the package up2date

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Preisschild
Copy link
Contributor Author

I couldn't find anything in the nixpkgs manual about using a fork of a package.

If this MR is wrong to overwrite the old package, please let me know.

prusnak
prusnak approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You might consider reformatting with nixpkgs-fmt tool to get whitespace formatting correctly, but that's optional

@Preisschild
Copy link
Contributor Author

I've re-formated it again with nixpkgs-fmt.

@ofborg ofborg bot requested a review from kalbasit December 20, 2020 02:58
@prusnak prusnak merged commit f9a60fc into NixOS:master Dec 20, 2020
@Preisschild Preisschild deleted the improvement/stern-use-fork branch January 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace wrecker/stern with stern/stern in nixpkgs.stern
2 participants
@Preisschild @prusnak