Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: use auto diskSize for make-disk-image #107212

Merged
merged 1 commit into from Apr 22, 2021

Conversation

Lassulus
Copy link
Member

since we now have auto size for disk image we should actually use them where its convenient.
what I did previously: #89331

Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Have not tested the build of any of those...

@SuperSandro2000
Copy link
Member

@ofborg eval

@Mic92 Mic92 merged commit 18ffe0d into NixOS:master Apr 22, 2021
@grahamc
Copy link
Member

grahamc commented Apr 24, 2021

Partially reverted in #120481, but I suspect this whole PR should be reverted until the problem is resolved: the auto value uses the bytes on disk value from du, not the length of the file. Since most of our builders run ZFS with compression, these images fail to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants