Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: 4.3.0.1 -> 4.3.1 #107205

Merged
1 commit merged into from Dec 19, 2020
Merged

qbittorrent: 4.3.0.1 -> 4.3.1 #107205

1 commit merged into from Dec 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from Anton-Latukha December 19, 2020 16:40
@ghost ghost merged commit 9e2c96b into NixOS:master Dec 19, 2020
@Anton-Latukha
Copy link
Contributor

Oh, late to review 0:-)

Thanks.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anton-Latukha @prusnak