Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsmartcols: init at v2.36.1 #107207

Merged
merged 2 commits into from Dec 21, 2020
Merged

libsmartcols: init at v2.36.1 #107207

merged 2 commits into from Dec 21, 2020

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Dec 19, 2020 •
edited

Motivation for this change

A requirement for an upcoming package I'm working on (microdnf/libdnf)

This library is a bit weird in that it's part of a different repo (https://github.com/karelzak/util-linux/tree/master/libsmartcols).
That being said, it compiles, I was able to use it as a dependency for libdnf and the build output looks complete (this one s on darwin, hence the dylib):

% find /nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/bin
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/include
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/include/libsmartcols
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/include/libsmartcols/libsmartcols.h
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/sbin
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/lib
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/lib/pkgconfig
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/lib/pkgconfig/smartcols.pc
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/lib/libsmartcols.1.dylib
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/lib/libsmartcols.la
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/lib/libsmartcols.dylib
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/man
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/man/man5
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/man/man5/terminal-colors.d.5.gz
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/man/man3
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/man/man8
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/man/man1
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/bash-completion
/nix/store/c0fsi4h9n9yiapwzayx2ac78wvbiqwa7-libsmartcols/share/bash-completion/completions
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 19, 2020

Result of nixpkgs-review pr 107207 run on x86_64-darwin 1

1 package built:
  • libsmartcols

@rb2k
Copy link
Contributor Author

rb2k commented Dec 19, 2020

Result of nixpkgs-review pr 107207 run on x86_64-linux 1

1 package built:
  • libsmartcols

flokli
flokli requested changes Dec 21, 2020
View reviewed changes
pkgs/development/libraries/libsmartcols/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libsmartcols/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libsmartcols/default.nix Outdated Show resolved Hide resolved
@rb2k rb2k requested a review from flokli December 21, 2020 18:54
@rb2k
Copy link
Contributor Author

rb2k commented Dec 21, 2020

@flokli Applied the suggestions!

@flokli flokli merged commit 4de1062 into NixOS:master Dec 21, 2020
@rb2k rb2k deleted the add_libsmartcols branch December 21, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rb2k @flokli