Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.py3status: add file as runtime dependancy #106926

Merged
merged 1 commit into from Jan 18, 2021
Merged

python3Packages.py3status: add file as runtime dependancy #106926

merged 1 commit into from Jan 18, 2021

Conversation

thornycrackers
Copy link
Contributor

Motivation for this change

This helps to resolve issues:

If I install the py3status package without also installing file I get errors trying to execute py3status -c my/config/path. I updated this file locally and ran nix-build -A python3Packages.py3status and then tested the py3status

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samb96
Copy link
Contributor

samb96 commented Dec 15, 2020

Result of nixpkgs-review pr 106926 1

3 packages built:
  • python37Packages.py3status
  • python38Packages.py3status
  • python39Packages.py3status

@samb96
Copy link
Contributor

samb96 commented Dec 15, 2020

@GrahamcOfBorg eval

@SuperSandro2000 SuperSandro2000 changed the title py3status: add file as runtime dependancy python3Packages.py3status: add file as runtime dependancy Jan 18, 2021
@SuperSandro2000 SuperSandro2000 merged commit 21160da into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thornycrackers @samb96 @SuperSandro2000 @Janik-Haag