Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flightgear: 2020.1.3 -> 2020.3.4 #106929

Merged
merged 2 commits into from Dec 17, 2020
Merged

flightgear: 2020.1.3 -> 2020.3.4 #106929

merged 2 commits into from Dec 17, 2020

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Dec 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Might tick of the requirements for #77799

@samb96
Copy link
Contributor

samb96 commented Dec 15, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from 7c6f434c December 15, 2020 18:29
@veprbl
Copy link
Member

veprbl commented Dec 17, 2020

@GrahamcOfBorg build flightgear

@aanderse
Copy link
Member

It won't build. Blacklisted because of size. Have to build locally to confirm.

veprbl
veprbl approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl changed the title Flightgear flightgear: 2020.1.3 -> 2020.3.4 Dec 17, 2020
@veprbl veprbl merged commit 2bb504e into NixOS:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wucke13 @samb96 @veprbl @aanderse