Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r8125: 9.003.05 -> 9.004.01 #106936

Merged
merged 2 commits into from Jan 18, 2021
Merged

r8125: 9.003.05 -> 9.004.01 #106936

merged 2 commits into from Jan 18, 2021

Conversation

notpeelz
Copy link

@notpeelz notpeelz commented Dec 15, 2020 •
edited

Motivation for this change

Initially, I made a github mirror for r8125 when I submitted the original r8125 PR.
Turns out there was another mirror that was made for the AUR, so I used that instead (to avoid duplication of effort).
As of recently (2020-11-02), r8125 no longer exists on the AUR (not sure why either see edit).
I tried contacting the maintainer of the AUR repo but to no avail.

In this patch, I changed the derivation to use my original repo instead.

Edit: apparently the r8125 AUR package was deleted because it's now included in Linux >=5.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 106936 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.r8125
  • linuxPackages_hardkernel_latest.r8125
1 package failed to build:
  • linuxPackages-libre.r8125
16 packages built:
  • linuxPackages.r8125 (linuxPackages_5_4.r8125)
  • linuxPackages_4_14.r8125
  • linuxPackages_4_19.r8125
  • linuxPackages_4_4.r8125
  • linuxPackages_4_9.r8125
  • linuxPackages_5_10.r8125 (linuxPackages_latest.r8125)
  • linuxPackages_5_9.r8125
  • linuxPackages_hardened.r8125
  • linuxPackages_latest-libre.r8125
  • linuxPackages_latest_hardened.r8125
  • linuxPackages_latest_xen_dom0.r8125
  • linuxPackages_latest_xen_dom0_hardened.r8125
  • linuxPackages_testing_bcachefs.r8125
  • linuxPackages_xen_dom0.r8125
  • linuxPackages_xen_dom0_hardened.r8125
  • linuxPackages_zen.r8125

thiagokokada
thiagokokada reviewed Dec 31, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add some checks to avoid building this in kernel >=5.9 🤔 ?

@notpeelz
Copy link
Author

Yeah that's exactly what I said on the NixOS discord :)

@notpeelz
Copy link
Author

4640338c36af88b74550b995f425921729f0b59f is the latest commit that mentions r8125 in the kernel.

If I run git tag --contains=4640338c36af88b74550b995f425921729f0b59f, I get this:

v5.10
v5.10-rc1
v5.10-rc2
v5.10-rc3
v5.10-rc4
v5.10-rc5
v5.10-rc6
v5.10-rc7
v5.11-rc1
v5.9
v5.9-rc1
v5.9-rc2
v5.9-rc3
v5.9-rc4
v5.9-rc5
v5.9-rc6
v5.9-rc7
v5.9-rc8

I'm not quite sure how to check which patch versions the r8125 changes made it into.

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 106936 1

1 package failed to build:
  • linuxPackages-libre.r8125
17 packages built:
  • linuxPackages.r8125
  • linuxPackages_4_14.r8125
  • linuxPackages_4_19.r8125
  • linuxPackages_4_4.r8125
  • linuxPackages_4_9.r8125
  • linuxPackages_5_10.r8125
  • linuxPackages_5_9.r8125
  • linuxPackages_hardened.r8125
  • linuxPackages_latest-libre.r8125
  • linuxPackages_latest_hardened.r8125
  • linuxPackages_latest_xen_dom0.r8125
  • linuxPackages_latest_xen_dom0_hardened.r8125
  • linuxPackages_lqx.r8125
  • linuxPackages_testing_bcachefs.r8125
  • linuxPackages_xen_dom0.r8125
  • linuxPackages_xen_dom0_hardened.r8125
  • linuxPackages_zen.r8125

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106936 run on x86_64-linux 1

11 packages marked as broken and skipped:
  • linuxPackages_5_10.r8125
  • linuxPackages_5_9.r8125
  • linuxPackages_hardkernel_4_14.r8125
  • linuxPackages_hardkernel_latest.r8125
  • linuxPackages_latest-libre.r8125
  • linuxPackages_latest.r8125
  • linuxPackages_latest_hardened.r8125
  • linuxPackages_latest_xen_dom0.r8125
  • linuxPackages_latest_xen_dom0_hardened.r8125
  • linuxPackages_lqx.r8125
  • linuxPackages_zen.r8125
1 package failed to build and are new build failure:
  • linuxPackages-libre.r8125: log was empty
9 packages built:
  • linuxPackages.r8125 (linuxPackages_5_4.r8125)
  • linuxPackages_4_14.r8125
  • linuxPackages_4_19.r8125
  • linuxPackages_4_4.r8125
  • linuxPackages_4_9.r8125
  • linuxPackages_hardened.r8125
  • linuxPackages_testing_bcachefs.r8125
  • linuxPackages_xen_dom0.r8125
  • linuxPackages_xen_dom0_hardened.r8125

@SuperSandro2000 SuperSandro2000 merged commit 961dc12 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notpeelz @thiagokokada @SuperSandro2000 @louistakepillz