Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vim-lightline-coc #106932

Merged
merged 2 commits into from Dec 16, 2020
Merged

add vim-lightline-coc #106932

merged 2 commits into from Dec 16, 2020

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Dec 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@onsails
Copy link
Contributor Author

onsails commented Dec 14, 2020

Result of nixpkgs-review pr 106932 1

28 packages failed to build:
  • spacevim
  • vimPlugins.UltiSnips (vimPlugins.ultisnips)
  • vimPlugins.coc-fzf
  • vimPlugins.coc-nvim
  • vimPlugins.defx-nvim
  • vimPlugins.delimitMate
  • vimPlugins.denite (vimPlugins.denite-nvim)
  • vimPlugins.deol-nvim
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.fzf-vim
  • vimPlugins.ncm2-ultisnips
  • vimPlugins.nvim-highlite
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-lsputils
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.onedark-vim
  • vimPlugins.popfix
  • vimPlugins.telescope-nvim
  • vimPlugins.vim-lsp
  • vimPlugins.vim-one
  • vimPlugins.vim-plug
  • vimPlugins.vim-smoothie
  • vimPlugins.vim-smt2
  • vimPlugins.vim-snippets
  • vimPlugins.vimspector
19 packages built:
  • vimPlugins.nerdcommenter (vimPlugins.The_NERD_Commenter)
  • vimPlugins.YouCompleteMe
  • vimPlugins.awesome-vim-colorschemes
  • vimPlugins.coc-explorer
  • vimPlugins.far-vim
  • vimPlugins.gitgutter (vimPlugins.vim-gitgutter)
  • vimPlugins.glow-nvim
  • vimPlugins.nvim-treesitter-textobjects
  • vimPlugins.plenary-nvim
  • vimPlugins.popup-nvim
  • vimPlugins.vim-clap
  • vimPlugins.vim-devicons
  • vimPlugins.vim-go
  • vimPlugins.vim-illuminate
  • vimPlugins.vim-jsbeautify
  • vimPlugins.vim-lightline-coc
  • vimPlugins.vim-terraform
  • vimPlugins.vimtex
  • vimPlugins.vista-vim

Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here :)

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/106932

47 packages built:
spacevim vimPlugins.YouCompleteMe vimPlugins.awesome-vim-colorschemes vimPlugins.coc-explorer vimPlugins.coc-fzf vimPlugins.coc-nvim vimPlugins.defx-nvim vimPlugins.delimitMate vimPlugins.denite-nvim vimPlugins.deol-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-khard vimPlugins.deoplete-nvim vimPlugins.far-vim vimPlugins.fzf-vim vimPlugins.glow-nvim vimPlugins.ncm2-ultisnips vimPlugins.nerdcommenter vimPlugins.nvim-highlite vimPlugins.nvim-lspconfig vimPlugins.nvim-lsputils vimPlugins.nvim-tree-lua vimPlugins.nvim-treesitter vimPlugins.nvim-treesitter-textobjects vimPlugins.onedark-vim vimPlugins.plenary-nvim vimPlugins.popfix vimPlugins.popup-nvim vimPlugins.telescope-nvim vimPlugins.ultisnips vimPlugins.vim-clap vimPlugins.vim-devicons vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-illuminate vimPlugins.vim-jsbeautify vimPlugins.vim-lightline-coc vimPlugins.vim-lsp vimPlugins.vim-one vimPlugins.vim-plug vimPlugins.vim-smoothie vimPlugins.vim-smt2 vimPlugins.vim-snippets vimPlugins.vim-terraform vimPlugins.vimspector vimPlugins.vimtex vimPlugins.vista-vim

@jonringer jonringer merged commit a3428b6 into NixOS:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants