Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_zen: 5.9.14 -> 5.10.1 #107003

Merged
merged 1 commit into from Dec 21, 2020
Merged

linux_zen: 5.9.14 -> 5.10.1 #107003

merged 1 commit into from Dec 21, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Dec 16, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

cc @andresilva

@marvin-mk2 marvin-mk2 bot added the marvin label Dec 16, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 16, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@andresilva
Copy link
Member

Result of nixpkgs-review pr 107003 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
25 packages failed to build:
  • linuxPackages_zen.akvcam
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.evdi
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
47 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.gcadapter-oc-kmod
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11 (linuxPackages_zen.nvidia_x11_beta)
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.openafs (linuxPackages_zen.openafs_1_8)
  • linuxPackages_zen.openafs_1_9
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.r8168
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable ,linuxPackages_zen.zfsUnstable)

@andresilva
Copy link
Member

I guess some new kernel modules need changes to support 5.10.

@eyJhb
Copy link
Member

eyJhb commented Dec 16, 2020

evdi is fixed in a PR that hopefully will be merged soon.

Also coordination with this? #106916

@Atemu
Copy link
Member Author

Atemu commented Dec 17, 2020

linux_latest has been updeted to 5.10 already in master, I'm not so sure whether that bump is important.

@TredwellGit
Copy link
Member

It is important for using new kernel features.

@Atemu
Copy link
Member Author

Atemu commented Dec 18, 2020

Just ran into an error with dex2oatd while building an image with robotnix which I am not able to reproduce on 5.9-zen:

dex2oatd E 12-17 11:47:11  3370  3370 dex2oat.cc:2200] Failed to copy oat file to file: out/soong/cheeseburger/dex_apexjars_unstripped/system/framework/arm/apex.oat: Invalid argument
dex2oatd E 12-17 11:47:11  3370  3370 fd_file.cc:175] File out/soong/cheeseburger/dex_apexjars_unstripped/system/framework/arm/apex.oat wasn't explicitly flushed before destruction.
dex2oatd E 12-17 11:47:11  3370  3370 fd_file.cc:178] File out/soong/cheeseburger/dex_apexjars_unstripped/system/framework/arm/apex.oat wasn't explicitly closed before destruction.
dex2oatd F 12-17 11:47:11  3370  3370 fd_file.cc:180] Check failed: guard_state_ >= GuardState::kClosed (guard_state_=Base, GuardState::kClosed=Closed)

(at the end of the 2h build process of course...)

Have you ever run across something like this @danielfullmer?

Currently rebuilding with vanilla 5.10.

@danielfullmer
Copy link
Contributor

@Atemu No, I haven't seen that error message in any robotnix builds before.

@Atemu
Copy link
Member Author

Atemu commented Dec 18, 2020

Thanks!

The same happens on vanilla 5.10, so not a linux_zen-specific issue. (nix-community/robotnix#74)

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 21, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@Atemu
Copy link
Member Author

Atemu commented Dec 21, 2020

Oh yeah, should probably also mention over here that the issue above was most likely caused by ZFS and also happens on the vanilla 5.10 kernel.

I didn't test 5.10-zen very much because of this but the kernel itself was working fine when I did use it.

@7c6f434c 7c6f434c merged commit 4aa87cf into NixOS:master Dec 21, 2020
@7c6f434c
Copy link
Member

Back in the old days headers were the oldest kernel version available, not the latest, and it still was generally fine.

@andresilva andresilva mentioned this pull request Jan 2, 2021
Closed
10 tasks
@Atemu Atemu deleted the update/linux_zen branch January 2, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Atemu @andresilva @eyJhb @TredwellGit @danielfullmer @7c6f434c