Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqitch: package cleanup #106994

Merged
merged 1 commit into from Dec 22, 2020
Merged

sqitch: package cleanup #106994

merged 1 commit into from Dec 22, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

Package cleanup.

I'm not a user of sqitch so I only did minimal testing (ran a migration with mysql). I was specifically hoping for some darwin testing (@marsam ?) to make sure I didn't break anything there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @datafoo for possible testing too ❤️

@aanderse
Copy link
Member Author

@GrahamcOfBorg build sqitchMysql sqitchPg

marsam
marsam approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Darwin and NixOS

@aanderse
Copy link
Member Author

Thank you very much @marsam! Given basic testing on NixOS and your test on Darwin are you happy to merge?

matt-snider
matt-snider approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@matt-snider matt-snider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @aanderse - this is much cleaner.

@aanderse aanderse merged commit 1e6e7c2 into NixOS:master Dec 22, 2020
@aanderse aanderse deleted the sqitch branch December 22, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@matt-snider matt-snider matt-snider approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @marsam @matt-snider