Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notcurses: init at 2.1.0 #106993

Merged
merged 1 commit into from Dec 30, 2020
Merged

notcurses: init at 2.1.0 #106993

merged 1 commit into from Dec 30, 2020

Conversation

andir
Copy link
Member

@andir andir commented Dec 16, 2020

I'm forwarding this patch that I received via email:

commit 16b7254d1d1fce8f1d4e439ac3cbd491d1dfa622
Author: William Casarin <jb55@jb55.com>
Date:   Tue Dec 15 07:01:09 2020 -0800

    notcurses: init at 2.1.0

    This is a neat ncurses alternative. See the demo here:

    https://www.youtube.com/watch?v=cYhZ7myXyyg

    Here's something interesting to package after this:

    https://github.com/dankamongmen/growlight

    Message-Id: <20201215150109.30656-1-jb55@jb55.com>

You can find the submission in the archive.

@ofborg ofborg bot requested a review from jb55 December 16, 2020 02:19
@xaverdh
Copy link
Contributor

xaverdh commented Dec 17, 2020

Really interesting project!
Should this be split into a dev output for the library part and bin for the binaries maybe?

@xaverdh xaverdh mentioned this pull request Dec 17, 2020
Closed
@xaverdh
Copy link
Contributor

xaverdh commented Dec 17, 2020 •
edited

I built and tried it out, all binaries appear to run fine.

edit: But no audio with notcurses-view (might be intentional / just not implemented though?).

@andir
Copy link
Member Author

andir commented Dec 17, 2020 via email

@xaverdh
Copy link
Contributor

xaverdh commented Dec 17, 2020

On 08:58 17.12.20, xaverdh wrote: Really interesting project! Should this be split into a dev output for the library part and bin for the binaries maybe?
We could probably do that even thought I do not see much of a benefit (yet). It is mostly being used as library (I suppose?) and the binaries are mostly examples? Either way works for me.

I think the notcurses-view might be useful on its own, but yes this can wait until the library / project is more widely used.

@dankamongmen
Copy link
Contributor

I built and tried it out, all binaries appear to run fine.

edit: But no audio with notcurses-view (might be intentional / just not implemented though?).

no audio is intended, though it could certainly be added if people wanted it

@dankamongmen
Copy link
Contributor

One project that is packaged in Debian and Fedora, but I've not yet packaged for NixOS, is growlight. Another is snd. I'd be interested in producing a NixOS recipe for Growlight once Notcurses went in.

mcbeth
mcbeth approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@mcbeth mcbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked on my ubuntu+nixpkgs and my NixOS machine. It probably should go into the maintainer's thought queue to support the QR code stuff (I'll never need it, but it is an advertised part of the code base) in the future.

@xaverdh
Copy link
Contributor

xaverdh commented Dec 18, 2020 •
edited

This worked on my ubuntu+nixpkgs and my NixOS machine. It probably should go into the maintainer's thought queue to support the QR code stuff (I'll never need it, but it is an advertised part of the code base) in the future.

This requires packaging libqrencode, right? I actually tried to do this locally but it appears that notcurses expects to find the library files relative to its own source directory.. that was just me being stupid!

@jb55
Copy link
Contributor

jb55 commented Dec 18, 2020 via email

@dankamongmen
Copy link
Contributor

This worked on my ubuntu+nixpkgs and my NixOS machine. It probably should go into the maintainer's thought queue to support the QR code stuff (I'll never need it, but it is an advertised part of the code base) in the future.

This requires packaging libqrencode, right? I actually tried to do this locally but it appears that notcurses expects to find the library files relative to its own source directory..

no, that shouldn't be the case. on debian, i build against libqrcodegen-dev. on fedora, libqrcodegen-devel, etc. either way, the qrcodegen stuff is of pretty esoteric appeal.

@mcbeth
Copy link
Contributor

mcbeth commented Dec 18, 2020

default.nix.txt

I've attached a simple/sample qrcodegen default.nix that is enough to enable the support in notcurses. There's 6 other languages in that repo that I'm ignoring right now...

@jb55 @andir
notcurses: init at 2.1.0
08f1b26 
This is a neat ncurses alternative. See the demo here:

https://www.youtube.com/watch?v=cYhZ7myXyyg

Here's something interesting to package after this:

https://github.com/dankamongmen/growlight

Message-Id: <20201218142929.9912-1-jb55@jb55.com>
@andir andir force-pushed the ml2pr/notcurses-init-at-2-1-0 branch from 16b7254 to 08f1b26 Compare December 19, 2020 02:20
@andir
Copy link
Member Author

andir commented Dec 19, 2020

Added the dev output. Any more remarks besides the qrcodegen?

@mcbeth mind opening a PR for qrcodegen?

@mcbeth mcbeth mentioned this pull request Dec 19, 2020
Merged
10 tasks
@dankamongmen
Copy link
Contributor

so is this going in? (sorry, i'm a bit ignorant of the nixos workflow)

@jb55
Copy link
Contributor

jb55 commented Dec 30, 2020 via email

@andir andir merged commit 0f12442 into NixOS:master Dec 30, 2020
@andir andir deleted the ml2pr/notcurses-init-at-2-1-0 branch December 30, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@mcbeth mcbeth mcbeth approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andir @xaverdh @dankamongmen @jb55 @mcbeth