Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireshark: Do $PATH lookup in wireshark.desktop instead of hardcoding derivation #106996

Merged
merged 1 commit into from Dec 16, 2020
Merged

wireshark: Do $PATH lookup in wireshark.desktop instead of hardcoding derivation #106996

merged 1 commit into from Dec 16, 2020

Conversation

andir
Copy link
Member

@andir andir commented Dec 16, 2020

I'm forwarding this patch that I received via email:

commit 251349dac30e4de0d9d0c982ccbe4e12c3217ccb
Author: Klemens Nanni <klemens.nanni@siticom.de>
Date:   Wed Nov 18 23:30:58 2020 +0100

    wireshark: Do $PATH lookup in wireshark.desktop instead of hardcoding derivation

    See db236e588de "steam: Do $PATH lookup in steam.desktop [...]".
    tl;dr: Otherwise widget/panel/desktop icons in DEs like KDE break.

    As upstream's .desktop file does not contain any executable paths,
    simply avoid substitution.

    Message-Id: <97c3e797-d844-4d0a-9ccf-397745f83aeb@siticom.de>

@andir
wireshark: Do $PATH lookup in wireshark.desktop instead of hardcoding…
251349d 
… derivation

See db236e5 "steam: Do $PATH lookup in steam.desktop [...]".
tl;dr: Otherwise widget/panel/desktop icons in DEs like KDE break.

As upstream's .desktop file does not contain any executable paths,
simply avoid substitution.

Message-Id: <97c3e797-d844-4d0a-9ccf-397745f83aeb@siticom.de>
@ofborg ofborg bot requested review from fpletz and bjornfor December 16, 2020 03:03
@andir andir merged commit 3bc15cb into NixOS:master Dec 16, 2020
@andir andir deleted the ml2pr/PATCH-wireshark-Do-PATH-lookup-in-wireshark-desktop-instead-of-hardcoding-derivation branch December 16, 2020 14:07
@ryneeverett ryneeverett mentioned this pull request Jan 27, 2021
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @bjornfor