Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscodium: update script artifact names have changed #106997

Merged
merged 1 commit into from Dec 17, 2020
Merged

vscodium: update script artifact names have changed #106997

merged 1 commit into from Dec 17, 2020

Conversation

samuela
Copy link
Member

@samuela samuela commented Dec 16, 2020

The vscodium project is now releasing artifacts with slightly different naming: VSCodium-darwin-${VSCODIUM_VER}.zip is now VSCodium-darwin-x64-${VSCODIUM_VER}.zip. This is likely due to arrival of the new ARM-based macs. In any case, it does mean that we need to update update-vscodium.sh to pull the correct artifact down.

Motivation for this change

The current update script is broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samuela
vscodium: update script artifact names have changed
551ff76 
The vscodium project is now releasing artifacts with slightly different naming: `VSCodium-darwin-${VSCODIUM_VER}.zip` is now `VSCodium-darwin-x64-${VSCODIUM_VER}.zip`. This is likely due to arrival of the new ARM-based macs. In any case, it does mean that we need to update `update-vscodium.sh` to pull the correct artifact down.
@samuela
Copy link
Member Author

samuela commented Dec 17, 2020

cc maintainers @Synthetica @turion

@marsam marsam merged commit 230e0a3 into NixOS:master Dec 17, 2020
@samuela samuela deleted the patch-2 branch December 17, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuela @marsam