openconnect_pa: remove from nixpkgs #106989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessai
approved these changes
Dec 16, 2020
|
Removal is the correct course of action. You are correct |
|
Thanks. I don't have the permissions necessary to merge this PR, so I'm just waiting for a committer to see it. |
According to the README on [the website][1], this fork of OpenConnect is deprecated because the Palo Alto Networks VPN functionality has been upstreamed into OpenConnect 8.0 and higher. [1]: https://github.com/dlenski/openconnect
kini
force-pushed
the
openconnect_pa/remove-from-nixpkgs
branch
from
85bbb57
to
2546873
Compare
|
There seems to be a merge conflict now, but if you resolve that, I can merge it. |
|
Thanks for the offer. Unfortunately, it looks like the merge conflict is because PR #123123 duplicates this. That PR got merged in a week while this PR has been sitting around for more than half a year. Just the luck of the draw I guess 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the README on the website, this fork of OpenConnect
is deprecated because the Palo Alto Networks VPN functionality has
been upstreamed into OpenConnect 8.0 and higher.
Motivation for this change
As mentioned in the commit message,
openconnect_pais now deprecated because it's been upstreamed intoopenconnect.Pinging @chessai, who introduced this package in #50513.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)