Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunvox: 1.9.5d -> 1.9.6c #106998

Merged
merged 1 commit into from Jan 18, 2021
Merged

sunvox: 1.9.5d -> 1.9.6c #106998

merged 1 commit into from Jan 18, 2021

Conversation

deifactor
Copy link
Contributor

Motivation for this change

Updated to latest version.
Note that the 1.9.5d download link 404s.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@deifactor
sunvox: 1.9.5d -> 1.9.6c
1de2217 
Updated to latest version.
Note that the 1.9.5d download link 404s.
@ofborg ofborg bot requested a review from puffnfresh December 16, 2020 03:13
@tasmo tasmo mentioned this pull request Dec 16, 2020
Closed
10 tasks
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Jan 2, 2021 •
edited

Result of nixpkgs-review pr 106998 1

1 package built:
  • sunvox

Working fine and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/320

@SuperSandro2000 SuperSandro2000 merged commit 6555f30 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolfangAukang WolfangAukang WolfangAukang approved these changes

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deifactor @WolfangAukang @nixos-discourse @SuperSandro2000