[Gecko Bug 1682762] Handle byte addresses in stash server. #26976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.9 introduces a change like:
```
--- a/usr/lib64/python3.8/multiprocessing/connection.py
+++ b/usr/lib64/python3.9/multiprocessing/connection.py
@@ -73,6 +73,11 @@ def arbitrary_address(family):
if family == 'AF_INET':
return ('localhost', 0)
elif family == 'AF_UNIX':
+ # Prefer abstract sockets if possible to avoid problems with the address
+ # size. When coding portable applications, some implementations have
+ # sun_path as short as 92 bytes in the sockaddr_un struct.
+ if util.abstract_sockets_supported:
+ return f"\0listener-{os.getpid()}-{next(_mmap_counter)}"
return tempfile.mktemp(prefix='listener-', dir=util.get_temp_dir())
elif family == 'AF_PIPE':
return tempfile.mktemp(prefix=r'\\.\pipe\pyc-%d-%d-' %
```
Which means that we can get byte addresses for abstract sockets. Encode
them to ascii so that we can pass it around in the environment or what
not.
Differential Revision: https://phabricator.services.mozilla.com/D99875
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682762
gecko-commit: f2f341c6d43cfb9e8d4cdc37c922d814e57c7e20
gecko-reviewers: jgraham
wpt-pr-bot
approved these changes
Dec 21, 2020
This was referenced Jan 2, 2021
|
Any idea why only the Mac tests fail? The patch is a python 3.9 change and the tests seem fine for Windows (whatever the python version) |
|
The sync is done in #27228, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 introduces a change like:
Which means that we can get byte addresses for abstract sockets. Encode
them to ascii so that we can pass it around in the environment or what
not.
Differential Revision: https://phabricator.services.mozilla.com/D99875
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1682762
gecko-commit: f2f341c6d43cfb9e8d4cdc37c922d814e57c7e20
gecko-reviewers: jgraham