Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pip: 20.3 -> 20.3.4 #106943

Merged
merged 1 commit into from Feb 20, 2021
Merged

pythonPackages.pip: 20.3 -> 20.3.4 #106943

merged 1 commit into from Feb 20, 2021

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Dec 15, 2020 •
edited

Motivation for this change

pip 20.3.4 is slated to be the last version of pip to support Python 2 and Python 3. pip 21 has already been released which is Python 3 only.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Dec 15, 2020

Version in commit is incorrect.

By the way, these core packages will only be updated in a batch together with others.

@groodt groodt changed the title python: pythonPackages: pip 2.3 -> 2.3.2 pythonPackages.pip: 2.3 -> 2.3.3 Dec 15, 2020
@groodt
Copy link
Contributor Author

groodt commented Dec 15, 2020

By the way, these core packages will only be updated in a batch together with others.

Ok, I didn't realize. Which other packages should be bumped? If it is straightforward, I can add them to this PR. If it is only possible to bump them in a huge batch of all packages, I'd rather close the PR.

@groodt groodt changed the title pythonPackages.pip: 2.3 -> 2.3.3 pythonPackages.pip: 2.3 -> 2.3.4 Jan 27, 2021
@groodt groodt reopened this Jan 27, 2021
@groodt groodt changed the title pythonPackages.pip: 2.3 -> 2.3.4 pythonPackages.pip: 20.3 -> 20.3.4 Jan 27, 2021
@FRidh FRidh added this to In progress in Python batch upgrade via automation Feb 20, 2021
@FRidh
Copy link
Member

FRidh commented Feb 20, 2021

/rebase-staging

@github-actions
Copy link
Contributor

Failed to rebase

@FRidh FRidh changed the base branch from master to python-unstable February 20, 2021 10:32
@FRidh FRidh merged commit 33db081 into NixOS:python-unstable Feb 20, 2021
Python batch upgrade automation moved this from In progress to Done Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Python batch upgrade
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@groodt @FRidh