Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddccontrol-db: 20180908 -> 20201221 #106944

Merged
merged 1 commit into from Feb 11, 2021
Merged

ddccontrol-db: 20180908 -> 20201221 #106944

merged 1 commit into from Feb 11, 2021

Conversation

maddyblue
Copy link
Contributor

@maddyblue maddyblue commented Dec 15, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

0x4A6F
0x4A6F reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile there was an release, do you mind redoing it?

@jtojnar jtojnar changed the title ddccontrol-db: 20180908 -> 20201030 ddccontrol-db: 20180908 -> 20201221 Feb 11, 2021
jtojnar
jtojnar approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay: ddccontrol/ddccontrol-db@2018060...2020122

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Feb 11, 2021
@jtojnar jtojnar merged commit 0cf1f67 into NixOS:master Feb 11, 2021
@maddyblue maddyblue deleted the patch-1 branch February 11, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maddyblue @jtojnar @SuperSandro2000 @0x4A6F @Janik-Haag