Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: 1.2.141 -> 1.2.162 #106945

Merged
merged 1 commit into from Jan 3, 2021
Merged

vulkan: 1.2.141 -> 1.2.162 #106945

merged 1 commit into from Jan 3, 2021

Conversation

expipiplus1
Copy link
Contributor

Also improve metadata for vulkan-validation-layers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1
vulkan: 1.2.141 -> 1.2.162
075060c 
Also improve metadata for vulkan-validation-layers
@ofborg ofborg bot requested a review from Ralith December 15, 2020 04:57
@expipiplus1
Copy link
Contributor Author

Thanks for the approval, @Ralith. Is it possible to merge this now that the checks have also passed?

@expipiplus1
Copy link
Contributor Author

Have tested this now with a raytracing example and the validation layer works very well!

@expipiplus1
Copy link
Contributor Author

Is it possible to get this merged, please?

@spacekitteh
Copy link
Contributor

@Ralith

@spacekitteh
Copy link
Contributor

Have tested this now with a raytracing example and the validation layer works very well!

I'm waiting on this to test your Haskell RT example, lol

@Ralith
Copy link
Contributor

Ralith commented Dec 25, 2020 •
edited

@spacekitteh hi, I do not have merge permissions.

@expipiplus1
Copy link
Contributor Author

I'm waiting on this to test your Haskell RT example, lol

It runs with the older SDK still, but not with the validation layer (for the best though as otherwise my invalid Vulkan usage would be visible!)

@alyssais alyssais merged commit cbc4bd9 into NixOS:master Jan 3, 2021
@expipiplus1
Copy link
Contributor Author

Thanks!

@expipiplus1 expipiplus1 deleted the joe-vvl branch January 3, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@expipiplus1 @spacekitteh @Ralith @alyssais