Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8401: Drive-thru road stations can be connected at either end #8528

Merged
merged 1 commit into from Jan 8, 2021

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

In #8401 introduced a bug when checking the direction of road stations.

Description

Standard dead-end road stations can only be entered from ReverseDiagDir(road_dir), but drive-through stations can also be entered from road_dir itself.

Also, I added the town t parameter to the function description which I'd forgotten earlier.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit b08c66a into OpenTTD:master Jan 8, 2021
@2TallTyler 2TallTyler deleted the road_station_direction_fix branch January 8, 2021 17:57
@2TallTyler 2TallTyler restored the road_station_direction_fix branch February 24, 2021 21:44
@2TallTyler 2TallTyler deleted the road_station_direction_fix branch February 27, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants