Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ant-dracula-theme alias #108826

Merged
merged 1 commit into from Jan 9, 2021
Merged

remove ant-dracula-theme alias #108826

merged 1 commit into from Jan 9, 2021

Conversation

fuzzypixelz
Copy link
Contributor

@fuzzypixelz fuzzypixelz commented Jan 9, 2021

Motivation for this change

The attribute name for the "Ant Dracula" theme in all-packages.nix is still ant-dracula-theme, while aliases.nix throws an error if a user tries to use ant-dracula-theme instead of the new dracula-theme attribute name, since the latter only changed in nixpkgs-unstable.

This occurred due to an error made during a merge conflict resolve: cda9f4c#diff-29ed0f5fda84c91253503c1664d60a194a324e29518d472adf846f30b8db52e3R739

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Nice! But you need to change the base branch to release-20.09, this is where all updates to 20.09 are merged into. nixos-20.09 is the branch updated automatically by hydra.

@fuzzypixelz fuzzypixelz changed the base branch from nixos-20.09 to release-20.09 January 9, 2021 04:34
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would you mind changing the commit message to be ant-dracula-theme: remove erroneous alias in accordance with our CONTRIBUTING document? Congrats on your first Nixpkgs PR :)

Otherwise, everything LGTM.

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cole-h cole-h merged commit c97befe into NixOS:release-20.09 Jan 9, 2021
@fuzzypixelz fuzzypixelz deleted the ant-dracula-theme-alias-fix branch April 11, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants