Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.6.0 -> 0.7.1 #108802

Merged
merged 2 commits into from Jan 9, 2021
Merged

alacritty: 0.6.0 -> 0.7.1 #108802

merged 2 commits into from Jan 9, 2021

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jan 8, 2021

https://github.com/alacritty/alacritty/releases/tag/v0.7.0

alacritty/alacritty@v0.6.0...v0.7.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne, Mic92 and Ma27 January 8, 2021 19:06
@cole-h
Copy link
Member Author

cole-h commented Jan 8, 2021

I'll update to 0.7.1 whenever it gets released; looks like there are a few bugs that need ironing out (alacritty/alacritty#4677 (comment)).

@cole-h cole-h marked this pull request as draft January 8, 2021 19:26
@cole-h cole-h changed the title alacritty: 0.6.0 -> 0.7.0 alacritty: 0.6.0 -> 0.7.1 Jan 9, 2021
@cole-h cole-h marked this pull request as ready for review January 9, 2021 15:19
@cole-h
Copy link
Member Author

cole-h commented Jan 9, 2021

0.7.1 was released, so this should be good to go.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108802 run on x86_64-linux 1

2 packages built:
  • alacritty
  • wio

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108802 run on x86_64-darwin 1

1 package built:
  • alacritty

@SuperSandro2000 SuperSandro2000 merged commit d00ed88 into NixOS:master Jan 9, 2021
@cole-h cole-h deleted the alacritty branch January 9, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@Mic92 Mic92 Awaiting requested review from Mic92

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @SuperSandro2000