Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expenses: init at 0.2.1 #108753

Merged
merged 2 commits into from Jan 11, 2021
Merged

expenses: init at 0.2.1 #108753

merged 2 commits into from Jan 11, 2021

Conversation

manojkarthick
Copy link
Member

Motivation for this change

An interactive command line expense logger
GitHub: https://github.com/manojkarthick/expenses

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 8, 2021 08:39
SuperSandro2000
SuperSandro2000 requested changes Jan 8, 2021
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/misc/expenses/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/expenses/default.nix Show resolved Hide resolved
pkgs/applications/misc/expenses/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/expenses/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/expenses/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/expenses/default.nix Outdated Show resolved Hide resolved
@manojkarthick
Copy link
Member Author

Thanks for the review @SuperSandro2000 - I've updated the PR with the requested changes.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108753 run on x86_64-darwin 1

1 package built:
  • expenses

@manojkarthick
maintainers: add manojkarthick
0a71bc0
@manojkarthick
expenses: init at 0.2.1
1c28232 
Motivation: An interactive command line expense logger
@manojkarthick
Copy link
Member Author

@SuperSandro2000 - All the comments have been resolved, and it seems to be building okay. Would you be able to approve and merge this when you get a chance? Thanks!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108753 run on x86_64-linux 1

1 package built:
  • expenses

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108753 run on x86_64-darwin 1

1 package built:
  • expenses

@SuperSandro2000 SuperSandro2000 merged commit 1109e24 into NixOS:master Jan 11, 2021
@manojkarthick
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manojkarthick @SuperSandro2000 @Janik-Haag