Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmview: init at 2.1 #108798

Merged
merged 5 commits into from Jan 18, 2021
Merged

rmview: init at 2.1 #108798

merged 5 commits into from Jan 18, 2021

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Jan 8, 2021

Motivation for this change

Adds rMview, a VNC viewer for
reMarkable tablets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu NickHu requested a review from siraben January 8, 2021 17:29
@Dyazz
Copy link
Contributor

Dyazz commented Jan 8, 2021

Result of nixpkgs-review pr 108798 1

1 package built:
  • rmview

@siraben
Copy link
Member

siraben commented Jan 8, 2021

Result of nixpkgs-review pr 108798 run on x86_64-darwin 1

1 package built:
  • rmview

@NickHu @SuperSandro2000
Update pkgs/applications/misc/remarkable/rmview/default.nix
8b4e609 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108798 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@siraben
Copy link
Member

siraben commented Jan 9, 2021

@SuperSandro2000 The segfault happens because you enabled sandboxing on Darwin.

@siraben siraben mentioned this pull request Jan 9, 2021
Closed
NickHu and others added 2 commits January 18, 2021 14:00
@NickHu @siraben
Update pkgs/applications/misc/remarkable/rmview/default.nix
1ad9e6b 
Co-authored-by: Ben Siraphob <bensiraphob@gmail.com>
@NickHu @siraben
Update pkgs/applications/misc/remarkable/rmview/default.nix
3b03c18 
Co-authored-by: Ben Siraphob <bensiraphob@gmail.com>
@NickHu NickHu requested a review from siraben January 18, 2021 14:00
@siraben
Copy link
Member

siraben commented Jan 18, 2021

Result of nixpkgs-review pr 108798 run on x86_64-darwin 1

1 package failed to build:
  • rmview

@siraben
Copy link
Member

siraben commented Jan 18, 2021

That's strange, I have rmview successfully packaged on my own.

@siraben
Copy link
Member

siraben commented Jan 18, 2021

Ok it's definitely due to sandbox being enabled by nix-review.

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/siraben/.cache/nixpkgs-review/pr-108798-1/build.nix

siraben
siraben approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build will succeed w/out sandbox on Darwin.

@NickHu NickHu merged commit 5f6d409 into NixOS:master Jan 18, 2021
@NickHu NickHu deleted the rmview branch January 18, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@thiagokokada thiagokokada thiagokokada left review comments

@siraben siraben siraben approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NickHu @Dyazz @siraben @SuperSandro2000 @danieldk @thiagokokada