Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon ec2 utils #108804

Merged
merged 2 commits into from Jan 8, 2021
Merged

Amazon ec2 utils #108804

merged 2 commits into from Jan 8, 2021

Conversation

ketzacoatl
Copy link
Contributor

Motivation for this change

Adding amazon-ec2-utils as a new package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
Copy link
Contributor

nh2 commented Jan 8, 2021

All scripts work.

@nh2 nh2 merged commit 22b9910 into NixOS:master Jan 8, 2021
@nh2 nh2 mentioned this pull request Jan 14, 2021
Open
@nh2 nh2 mentioned this pull request Jan 27, 2021
Draft
10 tasks
nh2 added a commit to nh2/nixpkgs that referenced this pull request Jan 27, 2021
@nh2
amazon-ec2-utils: Merge with / replace ec2-utils
f39ef5d 
In NixOS#108804 `aws-ec2-utils` was packaged, not noticing that a much
older version of the same project was already packaged in nixpkgs
before as `ec2-utils`.

This commit merges the two:

* Amazon recently published the full source repo on GitHub and
  renamed the project (see `amazon-ec2-utils.spec` changelog):
  > Rename the project to amazon-ec2-utils
* The old one was extracted from a RPM, the new one is built from source.
* The new one is the more recent version 1.3.
* In the new one we hadn't installed udev rules yet; in the old we did.
  The merged version has both.
* Maintainers merged.
* `installCheck` added to test execution.
* Alias added for the old name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ketzacoatl @nh2 @Janik-Haag