Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.aiostream: init at 0.4.1 #108829

Merged
merged 1 commit into from Jan 9, 2021
Merged

python3Packages.aiostream: init at 0.4.1 #108829

merged 1 commit into from Jan 9, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented Jan 9, 2021

Motivation for this change

url: https://github.com/vxgmichel/aiostream
stars: 290
test coverage: 100%

seems like a pretty good library, and i was surprised to see we didn't have it already

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nixpkgs-review rev 0383c9c32dd --no-shell

Updating 99264011def..0383c9c32dd
Fast-forward
 pkgs/development/python-modules/aiostream/default.nix | 30 ++++++++++++++++++++++++++++++
 pkgs/top-level/python-packages.nix                    |  2 ++
 2 files changed, 32 insertions(+)
 create mode 100644 pkgs/development/python-modules/aiostream/default.nix

3 packages added:
python37Packages.aiostream (init at 0.4.1) python38Packages.aiostream (init at 0.4.1) python39Packages.aiostream (init at 0.4.1)

3 packages built:
python37Packages.aiostream python38Packages.aiostream python39Packages.aiostream

@SuperSandro2000
Copy link
Member

seems like a pretty good library, and i was surprised to see we didn't have it already

We mostly try to package libraries required by tools and things that are used really often because otherwise Pypi is just to big and is to much work to maintain. So we miss quite a lot from pypi which is okay.

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Jan 9, 2021

Of course, and I'm happy to keep this in my own project's nix expressions if you'd rather not include it. I am currently finding it useful in a project FWIW, and I thought others might benefit from it in nixpkgs.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108829 run on x86_64-linux 1

3 packages built:
  • python37Packages.aiostream
  • python38Packages.aiostream
  • python39Packages.aiostream

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108829 run on x86_64-darwin 1

3 packages built:
  • python37Packages.aiostream
  • python38Packages.aiostream
  • python39Packages.aiostream

@SuperSandro2000 SuperSandro2000 merged commit 3e5714a into NixOS:master Jan 9, 2021
@rmcgibbo rmcgibbo deleted the aiostream branch January 9, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmcgibbo @SuperSandro2000