Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: access_mode "none" is only available on GCC 11.1 and later #8526

Merged
merged 1 commit into from Jan 8, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

GCC 11 and later only have "none" as access_mode. There is no sane alternative for this problem.

Description

GCC 10 people complained; it broke stuff :D

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro previously approved these changes Jan 8, 2021
glx22
glx22 previously approved these changes Jan 8, 2021
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for mingw too.

@TrueBrain TrueBrain dismissed stale reviews from glx22 and LordAro via 62f0feb January 8, 2021 14:12
@TrueBrain TrueBrain changed the title Fix 639cfa43: access_mode "none" is only available on GCC 11 and later Revert: access_mode "none" is only available on GCC 11.1 and later Jan 8, 2021
…s supported before trying to use it."

This reverts commit c1fddb9 and 639cfa4.

access_mode "none" is only supported by GCC11, but introduced
after it branched. So there are GCC11.0s out there that do not
support it. We will have to wait for GCC11.1 to hit before we
can re-add this.
@TrueBrain TrueBrain merged commit fda1fbf into OpenTTD:master Jan 8, 2021
@TrueBrain TrueBrain deleted the gcc-11 branch January 8, 2021 14:25
@TrueBrain
Copy link
Member Author

https://gist.github.com/Milek7/3dd1f0d2bd6fd8422579055d7dbbd62f for when GCC 11.1 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants