Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox 84.0.2 #108770

Merged
merged 5 commits into from Jan 10, 2021
Merged

Firefox 84.0.2 #108770

merged 5 commits into from Jan 10, 2021

Conversation

FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Jan 8, 2021 •
edited

Motivation for this change

Mozilla announced a critical security vulnerabilities in various Firefox versions: https://www.mozilla.org/en-US/security/advisories/mfsa2021-01/

This will need backporting due to its security relevance (@NixOS/backports).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via NixOS test (nixos/tests/firefox.nix)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra January 8, 2021 14:04
@jonringer
Copy link
Contributor

@GrahamcOfBorg test firefox
@GrahamcOfBorg test firefox-esr

jonringer
jonringer approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming tests pass

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 10, 2021
@mohe2015
Copy link
Contributor

Tests seem to have passed. What about merging now?

@ajs124 ajs124 merged commit fe0ee32 into NixOS:master Jan 10, 2021
@FlorianFranzen FlorianFranzen deleted the firefox_update branch January 10, 2021 21:28
@erictapen erictapen mentioned this pull request Jan 12, 2021
Merged
10 tasks
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@jonringer jonringer jonringer approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FlorianFranzen @jonringer @mohe2015 @ajs124 @erictapen