Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentencepiece: 0.1.94 -> 0.1.95 #108756

Merged
merged 2 commits into from Jan 10, 2021
Merged

sentencepiece: 0.1.94 -> 0.1.95 #108756

merged 2 commits into from Jan 10, 2021

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jan 8, 2021

Motivation for this change

Changelog:

https://github.com/google/sentencepiece/releases/tag/v0.1.95

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pashashocky January 8, 2021 10:15
@danieldk
Copy link
Contributor Author

danieldk commented Jan 8, 2021

Hmpf. Upstream updated the tag to another commit. Let's hope this doesn't happen again.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108756 run on x86_64-linux 1

4 packages built:
  • python37Packages.sentencepiece
  • python38Packages.sentencepiece
  • python39Packages.sentencepiece
  • sentencepiece

@danieldk
Copy link
Contributor Author

danieldk commented Jan 9, 2021

Another upstream tag bump.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108756 run on x86_64-linux 1

4 packages built:
  • python37Packages.sentencepiece
  • python38Packages.sentencepiece
  • python39Packages.sentencepiece
  • sentencepiece

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 9, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108756 run on x86_64-darwin 1

4 packages failed to build and are new build failures:
  • python37Packages.sentencepiece: log was empty
  • python38Packages.sentencepiece: log was empty
  • python39Packages.sentencepiece: log was empty
  • sentencepiece: log was empty

Failing because of gperftools fails to build.

@SuperSandro2000 SuperSandro2000 merged commit 5b977aa into NixOS:master Jan 10, 2021
@danieldk danieldk mentioned this pull request Jan 16, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashashocky pashashocky Awaiting requested review from pashashocky

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @SuperSandro2000