Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.aiowinreg: init at 0.0.3 #108809

Merged
merged 1 commit into from Jan 11, 2021
Merged

python3Packages.aiowinreg: init at 0.0.3 #108809

merged 1 commit into from Jan 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 8, 2021

Motivation for this change

Python module to parse the registry hive.

https://github.com/skelsec/aiowinreg

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title python3Packages.aiowinreg: init at 0.0.3 python36Packages.aiowinreg: init at 0.0.3 Jan 10, 2021
@SuperSandro2000
Copy link
Member

This package only works on python 3.6. Maybe it is not worth it adding it.

@fabaff fabaff changed the title python36Packages.aiowinreg: init at 0.0.3 python3Packages.aiowinreg: init at 0.0.3 Jan 10, 2021
@fabaff
Copy link
Member Author

fabaff commented Jan 10, 2021

This package only works on python 3.6. Maybe it is not worth it adding it.

3.6 is the minimal version. I made a deliberation error.

@fabaff
Copy link
Member Author

fabaff commented Jan 10, 2021

Result of nixpkgs-review pr 108809 1

3 packages built:
  • python37Packages.aiowinreg
  • python38Packages.aiowinreg
  • python39Packages.aiowinreg

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108809 run on x86_64-darwin 1

3 packages built:
  • python37Packages.aiowinreg
  • python38Packages.aiowinreg
  • python39Packages.aiowinreg

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108809 run on x86_64-linux 1

3 packages built:
  • python37Packages.aiowinreg
  • python38Packages.aiowinreg
  • python39Packages.aiowinreg

@SuperSandro2000 SuperSandro2000 merged commit ac42d25 into NixOS:master Jan 11, 2021
@fabaff fabaff deleted the aiowinreg branch January 11, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000