pythonPackages.*: Disable various checkPhases with zero tests run, libgda: Fix building with newest mysql, vtk_{7,8}: Fix compiling #108799
Conversation
There was a problem hiding this comment.
Even if there are no tests at this point in time, I don't think the checkPhase should be disabled. If upstream ever adds tests, we now have to remove the doCheck = false; line, rather than just bumping the version (and maybe disabling certain tests that don't work).
It takes an extra bit of time to figure out it has no tests and just move on to the next phase. Maybe it's just me, but I don't think the disabling of the checkPhase is necessary or desired.
It is a maintainers duty to keep up with this. Also most of the time we would need to add Also a maintainers duty is it to check if all dependencies are still required and the package works correctly. Also python is the only place where we execute those tests by default which most of the time do not reveal bugs in our packaging but code bugs. If we are doing pythomImportsCheck everywhere it is enough for the simpler packages. Complicated things like tensorflow or pandas require tests.
I didn't come up with it but jonringer and I think he knows what he is doing. If we update something I don't want to deal with failing tests which where not there before. |
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 29 packages failed to build and are new build failures:
60 packages built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 6 packages marked as broken and skipped:
32 packages failed to build and are new build failures:
44 packages built:
|
SuperSandro2000
force-pushed
the
fix-collection
branch
from
c15187b
to
694a376
Compare
| @@ -16673,13 +16673,15 @@ in | |||
| vte_290 = callPackage ../development/libraries/vte/2.90.nix { }; | |||
|
|
|||
| vtk_7 = libsForQt515.callPackage ../development/libraries/vtk/7.x.nix { | |||
| stdenv = gcc9Stdenv; | |||
There was a problem hiding this comment.
There are no releases for 3 years for 7.X and there is probably no fix with gcc10 and I couldn't find a branch for it.
| inherit (darwin) libobjc; | ||
| inherit (darwin.apple_sdk.libs) xpc; | ||
| inherit (darwin.apple_sdk.frameworks) Cocoa CoreServices DiskArbitration | ||
| IOKit CFNetwork Security ApplicationServices | ||
| CoreText IOSurface ImageIO OpenGL GLUT; | ||
| }; | ||
| vtk_8 = libsForQt515.callPackage ../development/libraries/vtk/8.x.nix { | ||
| stdenv = gcc9Stdenv; |
There was a problem hiding this comment.
There are no releases for a year for 8.X and there is probably no fix with gcc10 and I couldn't find a branch for it.
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 31 packages failed to build and are new build failures:
24 packages built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 14 packages failed to build and are new build failures:
53 packages built:
The label is not correct. Those build failures are not new. |
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 14 packages failed to build and are new build failures:
73 packages built:
|
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)