Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgme: fix build on darwin #108752

Merged
merged 1 commit into from Jan 8, 2021
Merged

gpgme: fix build on darwin #108752

merged 1 commit into from Jan 8, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 8, 2021

Motivation for this change

Fixes #108731
cc: @ahmedelgabri

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 8, 2021
@ofborg ofborg bot requested a review from primeos January 8, 2021 08:25
primeos
primeos approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks!

@primeos primeos merged commit bdc86af into NixOS:master Jan 8, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108752 run on x86_64-darwin 1

23 packages marked as broken and skipped:
  • almanah
  • atom
  • atom-beta
  • falkon
  • gmic-qt-krita
  • gnome-recipes
  • gnome3.nautilus-python
  • krunner-pass
  • latte-dock
  • libsForQt5.alkimia
  • libsForQt512.alkimia
  • libsForQt514.alkimia
  • libsForQt515.alkimia
  • maia-icon-theme
  • mail-notification
  • malcontent-ui
  • mate.mate-utils
  • odpdown
  • profanity
  • quassel
  • quasselClient
  • udiskie
  • virt-manager-qt
5 packages failed to build and are new build failures:
  • balsa: log was empty
  • dar: log was empty
  • libcryptui: log https://termbin.com/y43z
  • libdnf: log was empty
  • microdnf: log was empty
43 packages built:
  • aerc
  • afew
  • dino
  • gmime3
  • gpa
  • gpgme
  • gpgstats
  • grepm
  • haskellPackages.bindings-gpgme
  • haskellPackages.notmuch
  • libjcat
  • librepo
  • libsForQt5.qgpgme (libsForQt512.qgpgme)
  • libsForQt514.qgpgme
  • libsForQt515.qgpgme
  • lieer
  • mu
  • muchsync
  • mutt (mutt-with-sidebar)
  • nasty
  • neomutt
  • nix-prefetch-docker
  • notmuch
  • notmuch-addrlookup
  • phrasendrescher
  • python37Packages.gpgme
  • python37Packages.librepo
  • python37Packages.notmuch
  • python37Packages.notmuch2
  • python37Packages.pygpgme
  • python38Packages.gpgme
  • python38Packages.librepo
  • python38Packages.notmuch
  • python38Packages.notmuch2
  • python38Packages.pygpgme
  • python39Packages.gpgme
  • python39Packages.librepo
  • python39Packages.notmuch
  • python39Packages.notmuch2
  • python39Packages.pygpgme
  • ripasso-cursive
  • skopeo
  • sylpheed

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

lieer:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.notmuch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.notmuch2:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.notmuch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.notmuch2:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.notmuch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.notmuch2:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@marsam marsam deleted the fix-gpgme-darwin branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gpgme fails to build on macOS
3 participants
@marsam @SuperSandro2000 @primeos