New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many updates #108801
Many updates #108801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what other maintainers would prefer, but I would prefer this to be split in multiple commits. At least, one for the bump and other for the refactors (migrating to cmake, moving to libraries).
Result of 1 package failed to build:
2 packages built:
|
Moving files to more meaningful locations doesn't change the outputs. After all, if someone was crazy enough, all the packages could be put in a same directory... |
Yeah, I know, but the reason I am saying this is because this makes the review easier. For now, it is very difficult to understand what is changing because I can't really diff your changes thanks to the file you moved. If this was a separate commit I could look commit by commit to understand whats happening. |
Unbfortunately git is very dumb on this aspect. Even if you use git commands to highlight a change, it treats it as a delete-plus-create. On the case at point, libjson-rpc-cpp fails with this message:
|
Error reported here too: |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package failed to build and are new build failure:
2 packages built:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
I will erase the latest upload. It causes a massive rebuild. |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package failed to build and are new build failure:
3 packages built:
|
Being conservative, I included a new version instead of overwriting.
I am also fixing libjson-rpc-cpp in this commit. |
Result of 4 packages built:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages built:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 4 packages built:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)