Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osmium-tool: 1.12.1 → 1.13.0, libosmium: 2.15.6 → 2.16.0, pyosmium: 3.0.1 → 3.1.0 #108813

Merged
merged 3 commits into from Jan 9, 2021
Merged

osmium-tool: 1.12.1 → 1.13.0, libosmium: 2.15.6 → 2.16.0, pyosmium: 3.0.1 → 3.1.0 #108813

merged 3 commits into from Jan 9, 2021

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 8, 2021 •
edited

Motivation for this change
  • osmium-tool: 1.13.0 changelog

    • Now depends on libosmium 2.16.0 or greater

    • Has support for PBF lz4 compression which is enabled by default if the library is found

  • libosmium: 2.16.0 changelog
    • Add -DINSTALL_GDALCPP:BOOL=ON cmake flag to install gdalcpp.hpp
  • pyosmium: 3.1.0 changelog
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • osm2pgsql
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir requested a review from das-g January 8, 2021 21:09
@das-g
Copy link
Member

das-g commented Jan 8, 2021

Result of nixpkgs-review pr 108813 run on x86_64-linux 1

6 packages built:
  • libosmium
  • osm2pgsql
  • osmium-tool
  • python37Packages.pyosmium
  • python38Packages.pyosmium
  • python39Packages.pyosmium

das-g
das-g reviewed Jan 9, 2021
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it?

While unicode arrows (→) might look nicer, CONTRIBUTING.md seems to mandate -> in commit messages for version changes.

nixpkgs/.github/CONTRIBUTING.md

Lines 14 to 20 in 9ff1aa8

* Format the commit messages in the following way:
```
(pkg-name | nixos/<module>): (from -> to | init at version | refactor | etc)
(Motivation for change. Additional information.)
```

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108813 run on x86_64-darwin 1

6 packages built:
  • libosmium
  • osm2pgsql
  • osmium-tool
  • python37Packages.pyosmium
  • python38Packages.pyosmium
  • python39Packages.pyosmium

@sikmir
Copy link
Member Author

sikmir commented Jan 9, 2021

Does it?

While unicode arrows (→) might look nicer, CONTRIBUTING.md seems to mandate -> in commit messages for version changes.

nixpkgs/.github/CONTRIBUTING.md

Lines 14 to 20 in 9ff1aa8

* Format the commit messages in the following way:
```
(pkg-name | nixos/<module>): (from -> to | init at version | refactor | etc)
(Motivation for change. Additional information.)
```

As far as I see, → is used quite often last time (among others by core committers):

$ git log --all --grep='→' | wc -l
15228

So, I guess it's acceptable de facto. @FRidh, @jonringer, @jtojnar what do you think?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108813 run on x86_64-linux 1

6 packages built:
  • libosmium
  • osm2pgsql
  • osmium-tool
  • python37Packages.pyosmium
  • python38Packages.pyosmium
  • python39Packages.pyosmium

@SuperSandro2000
Copy link
Member

Ofborg picked the updates up correctly.

@SuperSandro2000 SuperSandro2000 merged commit 5ec6c8e into NixOS:master Jan 9, 2021
@sikmir sikmir deleted the osmium branch January 9, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-g das-g das-g left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @das-g @SuperSandro2000