Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvm2: 2.03.10 -> 2.03.11 #108775

Closed
wants to merge 1 commit into from
Closed

lvm2: 2.03.10 -> 2.03.11 #108775

wants to merge 1 commit into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 8, 2021

Motivation for this change

Upstream release: https://github.com/lvmteam/lvm2/blob/v2_03_11/WHATS_NEW

VDO support is built by default now, but is disabled in nixpkgs, because it can't find vdoformat.
AFAICT the kernel support for that still isn't upstream and it still seems kind of experimental, so I'd just ignore that for now and add it once it's either upstream of if anyone actually wants to use it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c January 8, 2021 15:17
@SuperSandro2000
Copy link
Member

/rebase-staging

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021

Failed to rebase on staging

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108775 run on x86_64-linux 1

1 package built:
  • lvm2

@ajs124 ajs124 closed this Jan 13, 2021
@ajs124 ajs124 deleted the upd/lvm2 branch January 13, 2021 01:01
@ajs124
Copy link
Member Author

ajs124 commented Jan 13, 2021

re-opened against staging in #109243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @SuperSandro2000