Fix #7972: show invalid orders to stations that don't accept your vehicle #8516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7972
Motivation / Problem
Having invalid orders that are shown as regular orders heavily confuses any user. So we have to do something to make it more .. clear what is going on. See #7972 for more detail.
Description
Before it was shown as a normal order, but the vehicle was skipping
it. This was rather unclear to the user. Now it is red and contains
text with some hints what is going on.
The text is prefixed rather than post-fixed, as we have many
post-fixes already.
For a train it looks like this:
For a bus it looks like this:
And in a very extreme case it looks like this:
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.