Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-sdk: 321.0.0 -> 322.0.0 #108774

Merged
merged 1 commit into from Jan 11, 2021
Merged

google-cloud-sdk: 321.0.0 -> 322.0.0 #108774

merged 1 commit into from Jan 11, 2021

Conversation

iAmMrinal0
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108774 run on x86_64-linux 1

1 package built:
  • google-cloud-sdk (google-cloud-sdk-gce)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108774 run on x86_64-darwin 1

1 package built:
  • google-cloud-sdk (google-cloud-sdk-gce)

@iAmMrinal0
Copy link
Member Author

Please add a pythonImportsCheck.

Could you help me out with what imports I'd check here? This tool exposes a suite of commands to work with rather than it being used as a library. So I'm confused with this. Or should we check for the commands that are exposed work(execute) or not? @SuperSandro2000

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 11, 2021 •
edited

I can't easily check the source code of this right now but an importsCheck checks if all dependencies are correct. If it is not to easy we can skip it.

@SuperSandro2000 SuperSandro2000 merged commit 98ac3af into NixOS:master Jan 11, 2021
@iAmMrinal0 iAmMrinal0 deleted the update/google-cloud-sdk branch January 12, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@stephenmw stephenmw Awaiting requested review from stephenmw

@pradyuman pradyuman Awaiting requested review from pradyuman

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iAmMrinal0 @SuperSandro2000