Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramboxpro: Migrate to using an AppImage #108787

Closed
wants to merge 1 commit into from
Closed

ramboxpro: Migrate to using an AppImage #108787

wants to merge 1 commit into from

Conversation

cawilliamson
Copy link
Member

Motivation for this change

The original implementation of this package has always been rather hacky and is certainly not a supported way to run Rambox Pro. The problem only got worse when the recent migration away from Electron v5.X due to security concerns and the package has been in a broken state ever since (it builds but doesn't run.)

This package change rectifies both of these problems - it moves Rambox Pro to using a supported method of run (AppImage) and allows it to be easily upgraded going forward without the constant need to hack together a new solution for whatever changes the Rambox team make.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

The original implementation of this package has always been rather hacky and is certainly not a supported way to run Rambox Pro. The problem only got worse when the recent migration away from Electron v5.X due to security concerns and the package has been in a broken state ever since (it builds but doesn't run.)

Are we going to migrate rambox-ce too 🤔 ?

@cawilliamson
Copy link
Member Author

Are we going to migrate rambox-ce too ?

I would doubt it because the Rambox package is maintained by someone else and I don't believe it uses Electron so the root cause of most of the problems with the Pro variant aren't present for the free version.

Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think Rambox CE is a Electron app too, it is just that they repackaged the .deb instead (that I think includes a copy of Electron).

BTW, the reason I am asking this is because it seems both packages could have the exact same derivation, just with different src inputs. This would make maintaining both versions easier.

cp ${appimageContents}/usr/share/icons/hicolor/256x256/apps/ramboxpro.png $out/share/icons/hicolor/256x256/apps/ramboxpro.png
'';
};

meta = with stdenv.lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdenv.lib is deprecated. Please use lib.

cp ${desktopItem}/share/applications/* $out/share/applications
cp ${appimageContents}/usr/share/icons/hicolor/256x256/apps/ramboxpro.png $out/share/icons/hicolor/256x256/apps/ramboxpro.png
'';
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There still seems to be some eval issues, or GitHub syntax highlighting is wrong (but I think this very unlikely).

@thiagokokada
Copy link
Contributor

I went and gave a try to converting both rambox and rambox-pro to use AppImage. This simplificated the derivation a lot: #109020

@cawilliamson cawilliamson deleted the fix/ramboxpro branch January 11, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants