New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ramboxpro: Migrate to using an AppImage #108787
Conversation
Are we going to migrate rambox-ce too 🤔 ? |
I would doubt it because the Rambox package is maintained by someone else and I don't believe it uses Electron so the root cause of most of the problems with the Pro variant aren't present for the free version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think Rambox CE is a Electron app too, it is just that they repackaged the .deb instead (that I think includes a copy of Electron).
BTW, the reason I am asking this is because it seems both packages could have the exact same derivation, just with different src inputs. This would make maintaining both versions easier.
cp ${appimageContents}/usr/share/icons/hicolor/256x256/apps/ramboxpro.png $out/share/icons/hicolor/256x256/apps/ramboxpro.png | ||
''; | ||
}; | ||
|
||
meta = with stdenv.lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.lib
is deprecated. Please use lib
.
cp ${desktopItem}/share/applications/* $out/share/applications | ||
cp ${appimageContents}/usr/share/icons/hicolor/256x256/apps/ramboxpro.png $out/share/icons/hicolor/256x256/apps/ramboxpro.png | ||
''; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There still seems to be some eval issues, or GitHub syntax highlighting is wrong (but I think this very unlikely).
I went and gave a try to converting both |
Motivation for this change
The original implementation of this package has always been rather hacky and is certainly not a supported way to run Rambox Pro. The problem only got worse when the recent migration away from Electron v5.X due to security concerns and the package has been in a broken state ever since (it builds but doesn't run.)
This package change rectifies both of these problems - it moves Rambox Pro to using a supported method of run (AppImage) and allows it to be easily upgraded going forward without the constant need to hack together a new solution for whatever changes the Rambox team make.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)