Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openiscsi: 2.1.2 -> 2.1.3 #108821

Merged
merged 2 commits into from Jan 9, 2021
Merged

openiscsi: 2.1.2 -> 2.1.3 #108821

merged 2 commits into from Jan 9, 2021

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 9, 2021 •
edited

Motivation for this change

https://github.com/open-iscsi/open-iscsi/releases/tag/2.1.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cleverca22 and zaninime January 9, 2021 00:31
@markuskowa markuskowa requested a review from ajs124 January 9, 2021 00:46
@fabaff
Copy link
Member

fabaff commented Jan 9, 2021

Result of nixpkgs-review pr 108821 run on x86_64-linux 1

1 package built:
  • openiscsi

fabaff
fabaff reviewed Jan 9, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ ./openiscsi/bin/iscsiadm --help
iscsiadm -m discoverydb [-hV] [-d debug_level] [-P printlevel] [-t type -p ip:port -I ifaceN ... [-Dl]] | [[-p ip:port -t type] [-o operation] [-n name] [-v value] [-lD]] 
iscsiadm -m discovery [-hV] [-d debug_level] [-P printlevel] [-t type -p ip:port -I ifaceN ... [-l]] | [[-p ip:port] [-l | -D]] 
[...]

Please update license = licenses.gpl2; to gpl2Plus. gpl2 is obsolete and upstream is mentioning or (at your option) any later version. Thanks.

Otherwise, looks good to me.

@ajs124 ajs124 merged commit 257cbbc into NixOS:master Jan 9, 2021
@markuskowa markuskowa deleted the upd-openiscsi branch January 9, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@zaninime zaninime zaninime approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @fabaff @zaninime @ajs124