Fix: don't allow free-wagon-chains to exceed max-train-length #8533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix #8295, but prevents any future AIs from ever getting in this state.
Motivation / Problem
In #8295 the AI created a very very very long free-wagon chain. This made me wonder why this was allowed. Trains are limited by a max length after all, so why not free-wagon chains?
This PR limits free-wagon chains under the same conditions trains are limited.
Description
This makes no sense, that a free-wagon-chain could be larger than
the maximum length of a train, as you cannot put an engine in
front of that anyway. And it prevents run-away AIs making very
silly long free-wagon-chains.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.