-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0ad: fix build by using gcc9Stdenv #108761
Conversation
@IvarWithoutBones I didn't realize |
Result of 1 package marked as broken and skipped:
|
05a4b8f
to
cbdbc0f
Compare
Note that the package is not actually broken, it just depends on something marked as insecure. |
|
Huh, that's weird. When I run Edit: When rebasing master I get the same error. I'll look into it. |
cbdbc0f
to
457b3e2
Compare
457b3e2
to
6df485f
Compare
Looks like 9bb3fcc broke the build by not replacing one pkgconfig that should have been replaced. I added a commit that fixes this. |
9bb3fcc missed one important rename of pkgconfig, breaking the build.
6df485f
to
2ce4aa8
Compare
@@ -50,7 +50,7 @@ stdenv.mkDerivation rec { | |||
# Workaround invalid pkg-config name for mozjs | |||
mkdir pkg-config | |||
ln -s ${spidermonkey_38}/lib/pkgconfig/* pkg-config/mozjs-38.pc | |||
PKG_CONFIG_PATH="$PWD/pkgconfig:$PKG_CONFIG_PATH" | |||
PKG_CONFIG_PATH="$PWD/pkg-config:$PKG_CONFIG_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We deliberately left those out because most of the time they where wrong.
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
Motivation for this change
The 0ad build fails since gcc 10 was made default with this error:
This changes the 0ad derivation to use the gcc9Stdenv.
Things done
Played a few games using this build method.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)