Add missing jsapi tests for wasm reference-types proposal #27099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbezhetskov
force-pushed
the
add-tests-for-wasm-table
branch
from
0909bb3
to
f4d96c7
Compare
dbezhetskov
force-pushed
the
add-tests-for-wasm-table
branch
from
f4d96c7
to
e589517
Compare
Ms2ger
requested changes
Jan 11, 2021
…ctor and Table.set
dbezhetskov
force-pushed
the
add-tests-for-wasm-table
branch
from
e589517
to
14620a7
Compare
Ms2ger
approved these changes
Jan 14, 2021
Comment on lines
+23
to
+26
| test(() => { | ||
| const argument = { "element": "i32", "initial": 3 }; | ||
| assert_throws_js(TypeError, () => new WebAssembly.Table(argument)); | ||
| }, "initialize table with a wrong element value"); |
There was a problem hiding this comment.
I realized I haven't actually specced this behaviour. Will fix.
eqrion
reviewed
Jan 22, 2021
| @@ -0,0 +1,49 @@ | |||
| // META: global=window,dedicatedworker,jsshell | |||
| // META: script=assertions.js | |||
| // META: script=/wasm/jsapi/wasm-constants.js | |||
There was a problem hiding this comment.
Was this intentional? I'm not seeing a wasm-constants.js file in this location?
There was a problem hiding this comment.
Oh, this was removed in #16326. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebAssembly reference types proposal adds optional initializing parameter for Table.ctor, Table.grow js apis and makes the second parameter for Table.set optional.
The link to the spec: https://webassembly.github.io/reference-types/js-api/index.html#tables.
We already have tests for Table.grow but tests for Table.ctor and Table.set are missed.
This PR adds these missing tests.