Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codechange: Check if access __attribute__ is supported before trying to use it. #8523

Merged
merged 1 commit into from Jan 8, 2021
Merged

Codechange: Check if access __attribute__ is supported before trying to use it. #8523

merged 1 commit into from Jan 8, 2021

Conversation

Milek7
Copy link
Contributor

@Milek7 Milek7 commented Jan 8, 2021

Motivation / Problem

639cfa4 introduced warnings about using unknown access __attribute__ in older compilers.

Description

Use __has_attribute check as recommended on https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fattribute.html

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro merged commit c1fddb9 into OpenTTD:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Milek7 @LordAro