Motivation / Problem

#7328 missed a case where a new game doesn't reset _file_to_saveload.abstract_ftype. This could make restart behave rather weird and unpredictable.

#8469, despite the way of wording, does have a point, which was already brought up in a comment in the original PR. Basically, "restart" and "reload" really are two different words, with different meaning. The new "restart" as accepted by #7328 acted in a way many people would not expect, especially as you are already used to the old one.

To top it off, the console command help-text was never changed, making it even more confusing.

Description

In this PR I opted to revert the change to "restart" from #7328, and reintroduce it as "reload". As we haven't had a release since the introduction of that PR, this should be fine. Now people who are used to the way the old command worked, can keep using it that way. Those who fancy the new way, can use that to.

In my world, the naming makes more sense this way:

• If you want to restart a map, I expect it to be clean of trains, companies, etc.
• If I want to reload a map, I expect to have exactly that: a reload of what I last loaded the game with.

This was echo'd by several comments in #7328.

I went through these use-case:

• If I am an AI developer, I would like to use "restart", as that gives me the same map, clean slate, and the AI can go nuts.
• If I am an NewGRF developer, I would like to use "reload", as I would want to see the buildings I put down, the vehicles, etc.
• If I am a server owner, I would like to use "restart": a competitive game that repeats on the same map, can use "restart". If he has to upgrade or reboot his machine, he might have loaded the savegame from the reboot, but he still expects "restart" to begin from zero.

But most of all, I find it very weird to so drastically change an existing console command between 2 releases, without having a good argument not to name the new way different. The ones given in #7328 were not convincing to me, at all. But, truth be told, this is a personal itch, as I was mostly annoyed the help text was not updated to reflect reality :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • PR must be added to API tracker

Things to not forget after merge

• Update https://wiki.openttd.org/en/Manual/Console