Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs-cluster: 0.13.0 -> unstable-2020-10 #108822

Merged
merged 1 commit into from Jan 9, 2021
Merged

ipfs-cluster: 0.13.0 -> unstable-2020-10 #108822

merged 1 commit into from Jan 9, 2021

Conversation

c00w
Copy link
Contributor

@c00w c00w commented Jan 9, 2021 •
edited

ipfs-cluster hasn't had a release since may 2020, however go-ipfs needs
to be updated for support with go1.15 and go1.16 (1.14 goes out of
support in february).

I've requested they tag a new revision, but until then we'll have to use
an unstable version.

I've re enabled the tests since they pass and are critical to catch
errors within ipfs-cluster (and in general make maintenance easier). One
test failed, so I manually disabled it via a patch and .Skip()

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c00w
Copy link
Contributor Author

c00w commented Jan 9, 2021

@bqv ^^

@c00w c00w mentioned this pull request Jan 9, 2021
Merged
10 tasks
@bqv
Copy link
Contributor

bqv commented Jan 9, 2021

cc #100871

@ofborg ofborg bot requested review from jglukasik and kalbasit January 9, 2021 00:46
SuperSandro2000
SuperSandro2000 requested changes Jan 9, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the pr and commit message title to : ipfs-cluster: 0.13.0 -> unstable-2020-10-20

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108822 run on x86_64-linux 1

1 package built:
  • ipfs-cluster

@c00w
ipfs-cluster: 0.13.0 -> unstable-2020-10
eabc228 
ipfs-cluster hasn't had a release since may 2020, however go-ipfs needs
to be updated for support with go1.15 and go1.16 (1.14 goes out of
support in february).

I've requested they tag a new revision, but until then we'll have to use
an unstable version.

I've re enabled the tests since they pass and are critical to catch
errors within ipfs-cluster (and in general make maintenance easier). One
test failed, so I manually disabled it via a patch and .Skip()
@c00w c00w changed the title ipfs-cluster:: upgrage to unstable-2020-10 ipfs-cluster: 0.13.0 -> unstable-2020-10 Jan 9, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108822 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@SuperSandro2000 SuperSandro2000 merged commit b9a9f69 into NixOS:master Jan 9, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/brainstorming-for-rfc-pname-and-version/12873/2

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/brainstorming-for-rfc-pname-and-version/12873/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@bqv bqv bqv approved these changes

@jglukasik jglukasik Awaiting requested review from jglukasik

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c00w @bqv @SuperSandro2000 @nixos-discourse