Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpromhttp: 0.1.1 -> 0.1.3 #108823

Closed
wants to merge 1 commit into from
Closed

libpromhttp: 0.1.1 -> 0.1.3 #108823

wants to merge 1 commit into from

Conversation

cfsmp3
Copy link

@cfsmp3 cfsmp3 commented Jan 9, 2021

Motivation for this change

Minor update, but they merged the patches we were including manually.
They also fixed a floating point bug on histograms.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Minor update, but they merged the patches we were including manually.
They also fixed a floating point bug on histograms.
@purcell
Copy link
Member

purcell commented Jan 9, 2021

What's your take on the failures due to warnings that are promoted to errors? Is that something else that needs an upstream fix?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108823 run on x86_64-linux 1

1 package failed to build and are new build failure:
1 package built:
  • libprom

@cfsmp3
Copy link
Author

cfsmp3 commented Jan 9, 2021 via email

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108823 run on x86_64-darwin 1

1 package failed to build and are new build failure:
1 package built:
  • libprom

@SuperSandro2000
Copy link
Member

Well, those incompatible types the compiler is complaining about are actually pointers to equivalent () types. Can we let warnings be warnings? :-) () On most archs.

On Fri, Jan 8, 2021 at 6:23 PM Steve Purcell @.***> wrote: What's your take on the failures due to warnings that are promoted to errors? Is that something else that needs an upstream fix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#108823 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/ABNMTWPW7TKBGLG5QPD44QDSY64ZTANCNFSM4V3EWRCQ> .

Add -wno-error

@stale
Copy link

stale bot commented Jul 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 9, 2021
@Artturin Artturin closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants