Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultCrateOverrides: override crates necessary for building sequoia #108782

Merged
merged 2 commits into from Jan 9, 2021

Conversation

erictapen
Copy link
Member

Motivation for this change

Add some overrides. E.g. I'm maintaining a flake for Sequoia and it allows me to remove a bunch of manual overrides. Also every other person using the Sequoia library in a nix-built Rust crate would profit from this.

Con: These are overrides that aren't ever used in Nixpkgs itself, so it might happen that they bitrot and there is no way to know this without building a project that utilizes those crate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 04065a7 into NixOS:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants