Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tigervnc: 1.10.1 -> 1.11.0 (CVE-2020-26117) #108778

Merged
merged 1 commit into from Jan 9, 2021
Merged

tigervnc: 1.10.1 -> 1.11.0 (CVE-2020-26117) #108778

merged 1 commit into from Jan 9, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 8, 2021

Motivation for this change

ChangeLog: https://github.com/TigerVNC/tigervnc/releases/tag/v1.11.0
Also fixes CVE-2020-26117[1].

[1] https://nvd.nist.gov/vuln/detail/CVE-2020-26117, #100324

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 8, 2021
@ofborg ofborg bot requested a review from viric January 8, 2021 16:00
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108778 run on x86_64-linux 1

2 packages built:
  • crowbar
  • tigervnc

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108778 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • crowbar

@SuperSandro2000 SuperSandro2000 merged commit fc93c76 into NixOS:master Jan 9, 2021
@Ma27 Ma27 deleted the tigervnc-cve-2020-26117 branch January 9, 2021 22:49
@Ma27
Copy link
Member Author

Ma27 commented Jan 10, 2021

Ported to stable as 2829500.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @SuperSandro2000