Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft: Update script URL #107046

Merged
merged 1 commit into from Dec 16, 2020
Merged

minecraft: Update script URL #107046

merged 1 commit into from Dec 16, 2020

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

I just accidentally downgraded Minecraft because we depended on Arch's AUR and they were not up-to-date yet.
This change points the version logic at the source of truth for the Minecraft launcher.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Pinging people who have previously updated Minecraft:
@hyperfekt @cpages @TredwellGit

References:
flathub/com.mojang.Minecraft#36
https://bugs.mojang.com/secure/attachment/224554/launcher_log.txt <-- This shows us that the URL has been used since at least June 2019

@NeQuissimus NeQuissimus added the 6.topic: updaters Tooling for (semi-)automated updating of packages label Dec 16, 2020
@hyperfekt
Copy link
Contributor

Nice find on that URL. The part of their API that I tried using originally consistently returns versions older than are available in the AUR.

@NeQuissimus
Copy link
Member Author

@hyperfekt yeah, I found http://launchermeta.mojang.com/mc/launcher.json initially but it's old

@NeQuissimus NeQuissimus merged commit ca27235 into NixOS:master Dec 16, 2020
@NeQuissimus NeQuissimus deleted the mcupdate branch December 16, 2020 19:33
@maxdeviant maxdeviant mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: updaters Tooling for (semi-)automated updating of packages 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @hyperfekt